Change back productID to be a number #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes serialport#1278 The productID should be a number not a description string
|
I wish I had more hardware to test on, thank you for this. |
|
Can you get the tests to pass? |
reconbot
added a commit
that referenced
this pull request
Aug 7, 2017
|
No worries I got it |
|
Thanks for fixing! I was away this weekend so I did not see your message in time sorry. |
reconbot
added a commit
that referenced
this pull request
Aug 7, 2017
### Bug Fixes * **linux:** The productID should be a number not a description string ([#1279](#1279)) ([bf46f68](bf46f68)) * **tests:** fixup for [#1279](#1279) ([#1285](#1285)) ([56074f6](56074f6)) * **windows:** Add option to disable RTS ([#1277](#1277)) ([5b8d163](5b8d163)) * **windows:** Parse more types of pnpIds ([#1288](#1288)) ([0b554d7](0b554d7)), closes [#1220](#1220) ### Chores * **binaries:** Lets switch to prebuild! ([#1282](#1282)) ([8c36e99](8c36e99)) ### Features * **test:** tone down codecov comments ([#1289](#1289)) ([749ffac](749ffac)) ### BREAKING CHANGES * **binaries:** I'm considering the switch to `prebuild` a breaking change because it's substantially changes our install processes. It's also possible the install flags to ensure downloading or building from source has changed slightly. That's not our api per say, but it's enough. * **windows:** We previously hard coded to have RTS on for windows at all times it now default to off.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1278 The productID should be a number not a description string